Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for running b2aiprotocol #340

Closed
wants to merge 2 commits into from

Conversation

ibevers
Copy link

@ibevers ibevers commented Aug 15, 2024

No description provided.

@ibevers
Copy link
Author

ibevers commented Aug 15, 2024

I ran into a challenge similar to the one with the race item before, where the first element of arrays was getting extracted. Jordan and I came up with the fix in 8580a39 for it yesterday. It might have unintended side-effects, but so far, it doesn't seem to.

@satra
Copy link
Contributor

satra commented Aug 15, 2024

can you create an example in demo-protocol to illustrate the issue? mostly because i thought this was no longer an issue. so there must a case where this still happens.

@ibevers
Copy link
Author

ibevers commented Aug 16, 2024

Yes, it only seems to show up with nested activities. Since this fix unblocks me on interactively validating the mood protocol, I'm going to prioritize that over making a minimal example and giving a long explanation of the reasoning for this fix, but I will loop back to this.

@satra
Copy link
Contributor

satra commented Aug 31, 2024

i'm closing this as this should have been fixed (and upgraded) in the PR that was merged #343

@satra satra closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants